fix 4.7 return type error in _get_rid()#171
Open
thebuddyadrian wants to merge 1 commit into
Open
Conversation
|
Upgrading my project from Godot 4.6 to Godot 4.7, this fixed the issue for me. |
rsubtil
requested changes
Jun 20, 2026
rsubtil
left a comment
rsubtil
left a comment
Owner
There was a problem hiding this comment.
Thanks for the change! Just one extra change that's needed 😉
| else: | ||
| return 0 | ||
| return RID() | ||
| return _texture_3d.get_rid() if not _textures.is_empty() else 0 |
Owner
There was a problem hiding this comment.
Missing this spot:
Suggested change
| return _texture_3d.get_rid() if not _textures.is_empty() else 0 | |
| return _texture_3d.get_rid() if not _textures.is_empty() else RID() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading a project using the Controller Icons addon to 4.7, the
get_rid()method of ControllerIconTexture gives the following error:Cannot return value of type "int" because the function return type is "RID".This has been fixed by returningRID()instead of0.